Re: [PATCH -mm 06/12] split LRU lists into anon & file sets

[Balbir Singh]

* Rik van Riel <riel@xxxxxxxxxx> [2008-05-29 16:22:52]:

> From: Rik van Riel <riel@xxxxxxxxxx>
> 
> Split the LRU lists in two, one set for pages that are backed by
> real file systems ("file") and one for pages that are backed by
> memory and swap ("anon").  The latter includes tmpfs.
> 
> Eventually mlocked pages will be taken off the LRUs alltogether.
> A patch for that already exists and just needs to be integrated
> into this series.
> 
> This patch mostly has the infrastructure and a basic policy to
> balance how much we scan the anon lists and how much we scan
> the file lists. The big policy changes are in separate patches.
> 
> Signed-off-by: Rik van Riel <riel@xxxxxxxxxx>
> Signed-off-by: Lee Schermerhorn <Lee.Schermerhorn@xxxxxx>
>

Hi, Rik,

My problems with OOM continue, despite the changes incorporated into
memcontrol.c. While I am investigating the problem, the code below
seemed incorrect.

 
> +static inline void
> +del_page_from_active_file_list(struct zone *zone, struct page *page)
> +{
> +	del_page_from_lru_list(zone, page, LRU_INACTIVE_FILE);
>  }

Shouldn't this be del_page_from_lru_list(zone, page, LRU_ACTIVE_FILE)?

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/