Re: [patch 1/2] MTD: use list_for_each_entry() in add_mtd_device()

From: Matthias Kaehlcke
Date: Sat May 31 2008 - 09:35:27 EST


sorry, i forgot to tell quilt to refresh the patch, here comes the
good one

--

MTD: use list_for_each_entry() instead of list_for_each() in add_mtd_device()

Signed-off-by: Matthias Kaehlcke <matthias@xxxxxxxxxxxx>

Index: linux-2.6/drivers/mtd/mtdcore.c
===================================================================
--- linux-2.6.orig/drivers/mtd/mtdcore.c 2008-05-31
15:31:17.000000000 +0200
+++ linux-2.6/drivers/mtd/mtdcore.c 2008-05-31 15:32:19.000000000
+0200
@@ -53,7 +53,7 @@

for (i=0; i < MAX_MTD_DEVICES; i++)
if (!mtd_table[i]) {
- struct list_head *this;
+ struct mtd_notifier *not;

mtd_table[i] = mtd;
mtd->index = i;
@@ -72,8 +72,7 @@
DEBUG(0, "mtd: Giving out device %d to
%s\n",i, mtd->name);
/* No need to get a refcount on the module
containing
the notifier, since we hold the
mtd_table_mutex */
- list_for_each(this, &mtd_notifiers) {
- struct mtd_notifier *not =
list_entry(this, struct mtd_notifier, list);
+ list_for_each_entry(not, &mtd_notifiers, list)
{
not->add(mtd);
}

--
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona

I am incapable of conceiving infinity, and yet I do not accept finity
(Simone de Beauvoir)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/