Re: [patch 3/8] Make d_path() consistent across mount operations

From: Christoph Hellwig
Date: Sat May 31 2008 - 04:22:26 EST


On Thu, May 29, 2008 at 01:32:48PM +0200, Miklos Szeredi wrote:
> The path that __d_path() computes can become slightly inconsistent when it
> races with mount operations: it grabs the vfsmount_lock when traversing mount
> points but immediately drops it again, only to re-grab it when it reaches the
> next mount point. The result is that the filename computed is not always
> consisent, and the file may never have had that name. (This is unlikely, but
> still possible.)
>
> Fix this by grabbing the vfsmount_lock for the whole duration of
> __d_path().

Looks good, and lock holding times shouldn't be a problem either.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/