Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

From: Mike Frysinger
Date: Fri May 30 2008 - 00:19:15 EST


On Thu, May 29, 2008 at 5:29 PM, Christoph Lameter wrote:
> On Thu, 29 May 2008, Mike Frysinger wrote:
>> > You should not have to do this. This is the default alignment that also
>> > SLOB needs to follow. We need to align structures correctly for access to
>> > long long's.
>>
>> are you saying that slob is broken ? i see in mm/slob.c:
>> #ifndef ARCH_KMALLOC_MINALIGN
>> #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long)
>> #endif
>
> It should be long long instead.
>
> SLUB:
>
> #ifndef ARCH_KMALLOC_MINALIGN
> #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
> #endif
>
> SLAB:
>
> #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)

will you post a patch to do that (and ideally delete all of the
occurrences in asm-*/ where the minalign is defined to 8) ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/