Re: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.orgfor pnp devices with no ctl

[Alan Cox]

On Thu, 29 May 2008 14:25:58 -0400
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> Alan Cox wrote:
> > maybe_altstatus is crap naming but simply making ata_sff_altstatus fake a
> > reply in arbitary cases risks not catching mistakes and could mean we
> > don't catch corrupting mistakes which would be very bad indeed.
> 
> Please grep the remaining users, IMO you will find that's not really 
> true.  After your patch no core users remain, only ones in a few 
> scattered drivers that most likely want your logic (or a 
> simplified-for-that-controller version thereof).

I did check them all and review them and read the documentation right
back to the original 1010 controller behaviour. I stand by my comment.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/