Re: [PATCH 2/6] Werror: Hide epca_setup() as it's unused

From: Alan Cox
Date: Thu May 29 2008 - 14:50:23 EST

Next message: Alan Cox: "Re: [PATCH 3/6] Werror: Remove iiEllisCleanup() as it's unused."
Previous message: H. Peter Anvin: "Re: [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86boot decompressor."
In reply to: David Howells: "[PATCH 2/6] Werror: Hide epca_setup() as it's unused"
Next in thread: David Howells: "[PATCH 5/6] Werror: Remove the packed attribute from PofTimStamp_tagin the hysdn driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, 29 May 2008 19:17:31 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Hide epca_setup() by encasing it in #if 0 as it's unused.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

NAK - we don't hide bugs, we fix em.

EPCA setup either needs calling, or as I suspect is the case epca needs
deleting. Hiding the warning isn't useful
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Alan Cox: "Re: [PATCH 3/6] Werror: Remove iiEllisCleanup() as it's unused."
Previous message: H. Peter Anvin: "Re: [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86boot decompressor."
In reply to: David Howells: "[PATCH 2/6] Werror: Hide epca_setup() as it's unused"
Next in thread: David Howells: "[PATCH 5/6] Werror: Remove the packed attribute from PofTimStamp_tagin the hysdn driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]