Re: [PATCH] tmpfs: support aio

From: Hugh Dickins
Date: Thu May 29 2008 - 14:21:51 EST


On Wed, 28 May 2008, Andrew Morton wrote:
>
> hm. This version:
> is neater but generates 21 bytes more code. Stupid gcc.
>
> I don't believe we needed to check for count == 0? We'd just loop around
> N times doing nothing.

You're right, thanks, and that's hardly a path we need to optimize.
I was just blindly copying generic_file_aio_read, but they would
both benefit from your improvement. If you don't mind, I'll send
you a replacement patch for shmem.c, and a patch for filemap.c.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/