Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

From: Christoph Lameter
Date: Thu May 29 2008 - 11:01:19 EST


On Thu, 29 May 2008, David Howells wrote:

> > Could the nommu people either tell us what this is all about? Or junk the
> > code. This looks very wrong.
>
> ELF-FDPIC is currently using kobjsize() so that it can expand the heap/stack
> segment to fill up the entirety of its allocation. It's probably worth
> dropping that, though.
>
> NOMMU mmap() is using kobjsize()/ksize() to keep track of the number of bytes
> allocated and the amount of dead space. We can probably ditch that too.
>
> However, fs/proc/task_nommu.c uses kobjsize() quite a bit to determine how
> much metadata space a process is carrying around. We could just use sizeof(),
> I suppose, and not bother calculating the slack.

The nagging question here is: Why is page->private used in kobjsize()? A
special heap/stack setup?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/