Re: BUG/OOPS: Double Lock in fsl_usb2_udc.c

[Li Yang]

On Thu, 2008-05-29 at 02:23 -0700, David Brownell wrote:
> > On Wed, 28 May 2008 15:25:31 -0700 Eugene_Bordenkircher@xxxxxxxxxx wrote:
> > 
> > > Looking through other drivers, I have seen them releasing the lock 
> > > immediately before calling disconnect(), however, without being an expert 
> > > with this driver, I'm not entirely sure that is the best option here. 
> 
> Yeah, general policy is to drop the UDC spinlock whenever
> you call out to gadget driver code, since it may need to
> reenter for various reasons.  (Though if drivers adopt some
> other locking policy that works, that should be fine too.
> Multiple locks don't seem to be needed.)
> 

I will submit a patch to release the lock before calling disconnect().

- Leo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/