Re: block: make blktrace use per-cpu buffers for message notes

From: Jens Axboe
Date: Thu May 29 2008 - 03:23:27 EST


On Thu, May 29 2008, Andrew Morton wrote:
> On Thu, 29 May 2008 09:09:15 +0200 Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
>
> > So I dug back into the old archives, and the patch was actually done
> > by me back in feb 2006. Not sure I particularly like it or if it
> > even works in this forward ported version, but it should get the
> > point across. blktrace is the sole user of relay_reserve(), so I
> > think it would be OK to change the interface.
> >
> > This is clearly NOT 2.6.26 material though, but it's food for
> > thought (I hope).
>
> hm, it's not pretty, is it. I think I prefer the existing code unless
> there are other users of this.

It is not pretty, it's pretty much a hack :-)

So lets just keep the current code. It's an extra copy, but at
least it's nice'n clean.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/