Re: [patch][resend] provide rtc_cmos platform device, take 2

From: Andrew Morton
Date: Wed May 28 2008 - 19:38:46 EST


On Tue, 27 May 2008 15:23:06 +0400
Stas Sergeev <stsp@xxxxxxxx> wrote:

> RTC doesn't work with pnpacpi=off.
> The attached patch fixes the problem by creating the platform device for
> the RTC when PNP is disabled. This may also help running the PNP-enabled
> kernel on an older PCs.
>
> Signed-off-by: Stas Sergeev <stsp@xxxxxxxx>
> Cc: David Brownell <david-b@xxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> Cc: Adam Belay <ambx1@xxxxxxxxxx>
> CC: Russell King <rmk+lkml@xxxxxxxxxxxxxxxx>

So is everyone happy with this now?

It got lost from the changelog but IIRC this fixes a small sort-of regression
which was added in 2.6.25(?) because Stas switched drivers. I assume
that the incompatibility was unintentional.

So it might be 2.6.26 material, and possibly even 2.6.25.x?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/