Re: vt/fbcon: fix background color on line feed

From: Jan Engelhardt
Date: Wed May 28 2008 - 13:08:39 EST


On Tuesday 2008-05-27 21:33, thunder7@xxxxxxxxx wrote:
>
>I used to force my console to black-on-white by the command 'setterm
>inversescreen on'. This worked well. In 2.6.26-rc4, I get lots of black
>background characters. Something as simple as typing 'ls' multiple times
>until the screen scrolls gives black characters. I see them at the end
>of lines, I see spaces changed in black characters, I see lots of black.

commit 7f676fb7cf34dd2982d0cf79aeea7e5b06ad91eb
Author: Jan Engelhardt <jengelh@xxxxxxxxxx>
Date: Wed May 28 10:00:41 2008 +0200

vt: fix background color on line feed, DEC invert

Original report: """I used to force my console to black-on-white by
the command `setterm -inversescreen on`. In 2.6.26-rc4, I get lots of
black background characters."""

Another addendum to commit c9e587ab.
This was previously missed out since I was not aware of what
vc_decscnm was for.

Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>
---
drivers/char/vt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index fa1ffbf..b8b2498 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -434,7 +434,7 @@ static void update_attr(struct vc_data *vc)
vc->vc_blink, vc->vc_underline,
vc->vc_reverse ^ vc->vc_decscnm, vc->vc_italic);
vc->vc_video_erase_char = (build_attr(vc, vc->vc_color, 1, vc->vc_blink, 0, vc->vc_decscnm, 0) << 8) | ' ';
- vc->vc_scrl_erase_char = (build_attr(vc, vc->vc_def_color, 1, false, false, false, false) << 8) | ' ';
+ vc->vc_scrl_erase_char = (build_attr(vc, vc->vc_def_color, 1, false, false, vc->vc_decscnm, false) << 8) | ' ';
}

/* Note: inverting the screen twice should revert to the original state */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/