Re: [patch 06/11] x86: nmi_32/64.c - use apic_write_around insteadof apic_write

[Maciej W. Rozycki]

On Sat, 24 May 2008, Cyrill Gorcunov wrote:

> apic_write_around will be expanded to apic_write in 64bit mode
> anyway. Only a few CPUs (well, old CPUs to be precise) requires
> such an action. In general it should not hurt and could be cleaned
> up for apic_write (just in case)
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> ---

Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>

 Almost all local APIC write accesses must use apic_write_around().  The
notable exceptions are appropriately guarded accesses to the ESR (there is
no need ever to write to this register on Pentium processors and a read of
the register has side-effects) and pieces of code known never to run on
original Pentium processors.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/