Re: [PATCH] atmel_serial: Filter out FP during baud rate detection

From: Haavard Skinnemoen
Date: Wed May 28 2008 - 03:04:56 EST


"Andrew Victor" <avictor.za@xxxxxxxxx> wrote:
> > I made a change to u-boot that used the FP (Fractional Part) field of
> > BRGR to achieve more accurate baud rate generation. Unfortunately, the
> > atmel_serial driver looks at the whole BRGR register when trying to
> > detect the baud rate that the port is currently running at, so setting
> > FP to a nonzero value breaks the baud rate detection.
>
> > Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx>
>
> Acked-by: Andrew Victor <linux@xxxxxxxxxxxx>

Thanks.

> The FP (Fractional Part) is not supported on some AT91 processors
> (RM9200, SAM9261) though.
> Those bits in BRGR are undefined.

Yes...I guess that's one more reason to filter them out.

FWIW, the u-boot patch explicitly excludes those two processors,
falling back to the existing CD calculation code.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/