Re: [PATCH] call_usermodehelper() increase reliability

[Li Zefan]

KOSAKI Motohiro wrote:
> Now, call_usermodehelper_setup() uses GFP_ATOMIC.
> but it can return NULL _very_ easily.
> 
> GFP_ATOMIC is needed only when we can't sleep.
> and, GFP_KERNEL is robust and better.
> 
> thus, I add gfp_mask argument to call_usermodehelper_setup().
> 
> So, its caller pass below,
> 
> call_usermodehelper() and call_usermodehelper_keys(): 
> 	depend on 'wait' argument.
> call_usermodehelper_pipe():
> 	always GFP_KERNEL because always run under process context.
> orderly_poweroff():
> 	pass to GFP_ATOMIC because may run under interrupt context.
> 

I have no problem with this patch.

Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/