Re: [PATCH 3/8] debug printk infrastructure -compile fixes

[Andrew Morton]

On Thu, 22 May 2008 17:16:39 -0400
Jason Baron <jbaron@xxxxxxxxxx> wrote:

> 
> Signed-off-by: Jason Baron <jbaron@xxxxxxxxxx>
> ---
>  net/netfilter/nf_conntrack_pptp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
> index 97e54b0..7fea304 100644
> --- a/net/netfilter/nf_conntrack_pptp.c
> +++ b/net/netfilter/nf_conntrack_pptp.c
> @@ -65,7 +65,7 @@ void
>  			     struct nf_conntrack_expect *exp) __read_mostly;
>  EXPORT_SYMBOL_GPL(nf_nat_pptp_hook_expectfn);
>  
> -#ifdef DEBUG
> +#if defined(DEBUG) || defined(CONFIG_DYNAMIC_PRINTK_DEBUG)
>  /* PptpControlMessageType names */
>  const char *const pptp_msg_name[] = {
>  	"UNKNOWN_MESSAGE",

Does this imply that the patch series will break bisectability?  If so,
this fix should be merged into whichever patch introduces the build
breakage.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/