Re: [PATCH 2/5] sky2: don't warn if page allocation fails

From: Stephen Hemminger
Date: Tue May 27 2008 - 14:47:41 EST


On Thu, 22 May 2008 05:57:44 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> >
> > for (i = 0; i < sky2->rx_nfrags; i++) {
> > - struct page *page = alloc_page(GFP_ATOMIC);
> > + struct page *page = alloc_page(GFP_ATOMIC | __GFP_NOWARN);
> >
> > if (!page)
> > goto free_partial;
>
>
> IMO it's inappropriate to add these warnings to net drivers that
> properly check all return values.
>
> This approach is too maintenance intensive, and winds up fixing the same
> problem over and over again -- a hint that the fix is in the wrong place.
>
> Jeff
>
>

So the __GFP_NOWARN should go away and get replaced by GFP_WARN?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/