[PATCH 2/2] signals: change collect_signal() to return void

From: Oleg Nesterov
Date: Tue May 27 2008 - 12:57:49 EST


With the recent changes collect_signal() always returns true. Change it to
return void and update the single caller.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- 26-rc2/kernel/signal.c~4_CS_VOID 2008-05-27 19:06:55.000000000 +0400
+++ 26-rc2/kernel/signal.c 2008-05-27 20:54:49.000000000 +0400
@@ -338,7 +338,7 @@ unblock_all_signals(void)
spin_unlock_irqrestore(&current->sighand->siglock, flags);
}

-static int collect_signal(int sig, struct sigpending *list, siginfo_t *info)
+static void collect_signal(int sig, struct sigpending *list, siginfo_t *info)
{
struct sigqueue *q, *first = NULL;

@@ -372,7 +372,6 @@ still_pending:
info->si_pid = 0;
info->si_uid = 0;
}
- return 1;
}

static int __dequeue_signal(struct sigpending *pending, sigset_t *mask,
@@ -390,8 +389,7 @@ static int __dequeue_signal(struct sigpe
}
}

- if (!collect_signal(sig, pending, info))
- sig = 0;
+ collect_signal(sig, pending, info);
}

return sig;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/