Re: [RFC PATCH 1/2] mmc_spi: export probe and remove functions

[Pierre Ossman]

On Fri, 23 May 2008 22:28:34 +0400
Anton Vorontsov <avorontsov@xxxxxxxxxxxxx> wrote:

> ...so we'll able to write bindings for the OpenFirmware without
> messing with #ifdefs in the driver itself.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>

This looks extremely wrong. Encapsulating probe functions isn't exactly
in line with the device model and bound to confuse people.

Your patches doesn't give a complete picture of the OF side of things,
but can't you solve this by having an init callback somewhere?

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/