Re: [PATCH 2/3] slub: record page flag overlays explicitly

From: KOSAKI Motohiro
Date: Mon May 26 2008 - 00:41:45 EST


Hi

This patch works well on my box.
but I have one question.

> if (s->flags & DEBUG_DEFAULT_FLAGS) {
> - if (!SlabDebug(page))
> - printk(KERN_ERR "SLUB %s: SlabDebug not set "
> + if (!PageSlubDebug(page))
> + printk(KERN_ERR "SLUB %s: SlubDebug not set "
> "on slab 0x%p\n", s->name, page);
> } else {
> - if (SlabDebug(page))
> - printk(KERN_ERR "SLUB %s: SlabDebug set on "
> + if (PageSlubDebug(page))
> + printk(KERN_ERR "SLUB %s: SlubDebug set on "
> "slab 0x%p\n", s->name, page);
> }
> }

Why if(SLABDEBUG) check is unnecessary?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/