Re: [PATCHv2 04/28] cx25840: treat firmware data as const

[Tyler Trafford]

[cx25840-firmware.c]

Looks good to me.

Acked-By: Tyler Trafford <ttrafford@xxxxxxxxx>

Mike Isely wrote:

> I see that this change allocates a local buffer on the stack (sized by 
> FWSEND).  Though the buffer is small (48 bytes, see above paragraph), it 
> is controlled by a macro and thus leaves open the possibility that it 
> could be accidentally increased to a point where the stack gets 
> overflowed.  Seems like not a good idea, but either way it should not 
> affect the pvrusb2 driver.

Separate topic, but maybe the send size should be parameterized, so that 
the adapter can specify a maximum?
--
Tyler Trafford

A sect or party is an elegant incognito devised to save a man from
the vexation of thinking.
		-- Ralph Waldo Emerson, Journals, 1831
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/