Re: [PATCH -v2] x86: enable preemption in delay

From: Steven Rostedt
Date: Sun May 25 2008 - 09:44:48 EST



On Sun, 25 May 2008, Steven Rostedt wrote:

> +
> + /*
> + * It is possible that we moved to another CPU, and
> + * since TSC's are per-cpu we need to calculate
> + * that. The delay must guarantee that we wait "at
> + * least" the amount of time. Being moved to another
> + * CPU could make the wait longer but we just need to
> + * make sure we waited long enough. Rebalance the
> + * counter for this CPU.
> + */
> + if (unlikely(cpu != smp_processor_id())) {
> + cpu = smp_processor_id();
> + rdtscl(bclock);
> + }
> }
> while ((now-bclock) < loops);

BAH! expect version 3. :-p

This was compiled tested.

-- Steve

> preempt_enable();
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/