Re: [PATCH 2/2] Only print "Decompressing Linux" etc when 'noisy'is passed.

[Kristian HÃgsberg]

On Sat, May 24, 2008 at 09:28:21PM +0200, devzero@xxxxxx wrote:
> what about using "quiet" here instead ?
> 
> quiet is already the parameter to suppress boot messages, so introducing another one doesn`t make sense, imho.

I agree, and I wasn't looking to introduce a new parameter, I meant to
reuse 'debug'.  That is already used for increasing the log level
(see init/main.c).  Also, as it is, the decompressor already prints
error messages if something goes wrong, so there's not much point in
printing the debug spew.  I think it makes sense to default to not
print it.

> the early boot commandline parser was extended some time ago to support boolean options, see:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=32d0b9898029b7b3c7f161d31f57c4831d9049eb
> 
> this may shrink your patch , see example in arch/x86/boot/edd.c 

Unfortunately, that doesn't help me.  This code is run before the kernel
is decompressed and the only functions available are the ones in misc.c.
And I know the strnstr approach isn't quite smart enough the handle quoted
parameters and similar, but I think it strikes a good balance.

I'll send an updated patch that looks for 'debug' instead of 'noisy'.

thanks,
Kristian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/