Re: [PATCH 1/2] Use structs instead of hardcoded offsets in x86boot decompressor.

[Rik van Riel]

On Fri, 23 May 2008 17:59:27 -0400
Kristian HÃgsberg <krh@xxxxxxxxxx> wrote:

> Signed-off-by: Kristian HÃgsberg <krh@xxxxxxxxxx>

Acked-by: Rik van Riel <riel@xxxxxxxxxx>


> +static struct boot_params *real_mode;		/* Pointer to real-mode data */
> +static struct screen_info *rm_screen_info;	/* Pointer to real-mode data */

People who wonder why these pointers never get initialized: they
point to the zeropage, which of course lives at address zero.

/* The so-called "zeropage" */
struct boot_params {
	struct screen_info screen_info;                 /* 0x000 */
        struct apm_bios_info apm_bios_info;             /* 0x040 */
        __u8  _pad2[12];                                /* 0x054 */
        struct ist_info ist_info;                       /* 0x060 */
	...

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/