kernel coding style for if ... else which cross #ifdef

From: Steve French
Date: Fri May 23 2008 - 15:11:54 EST


A question splitting "else" and "if" on distinct lines vs. using an
extra line and extra #else came up as I was reviewing a proposed cifs
patch. Which is the preferred style?

#ifdef CONFIG_SOMETHING
if (foo)
something ...
else
#endif
if ((mode & S_IWUGO) == 0)

or alternatively

#ifdef CONFIG_SOMETHING
if (foo)
something ...
else if ((mode & S_IWUGO) == 0)
#else
if ((mode & S_IWUGO) == 0)
#endif


--
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/