Re: [PATCH] x86: Switch apm to unlocked_kernel

From: Stephen Rothwell
Date: Fri May 23 2008 - 09:23:56 EST

Hi Alan,

On Fri, 23 May 2008 12:06:17 +0100 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> Andrew shouts at me if I send him patches that don't fix the style of
> the lines around so you get some style changes even when I cut bits out
> of diffs. I think that approach is *stupid* too and style should be done
> after for the entire file.

Then let the maintainer (nominally me) shout at Andrew. I don't agree
with those style changes and we usually leave such purely stylistic
things to the maintainer of the file in question. If Andrew requires
these changes, then Andrew is wrong about this. It just confuses the
real changes and adds to the overheads of those trying to do reviews (of
which we have too few). And in this case "fix" is in the eye of the

If you (or Andrew) thinks that those style changes are necessary, then
send them separately and I will NAK them :-) In this case it is pure
churn for absolutely no gain whatsoever. Two of the hunks weren't even
anywhere near the real changes.

/me is letting the linux-next work go to his head :-)
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature