Re: [X86] Remove unnecessary code in 64bit CPU identification.

From: Dave Jones
Date: Thu May 22 2008 - 12:40:51 EST

On Wed, May 21, 2008 at 04:55:28PM -0700, H. Peter Anvin wrote:
> Dave Jones wrote:
> >
> > Moving along the same direction.. Moving the vendor specific bits out of setup_64.c
> > into cpu/ would go a long way towards killing of setup64.c. I took a first pass at doing this
> > in the diff below. So far I only looked at the AMD specific bits, and haven't done
> > a complete conversion to cpu_dev style initialisation as done on 32bit, but that
> > can easily be performed later after moving all the code out into its respective places.
> > (downside: a bunch of externs in the interim).
> >
> > comments on this before I go any further?
> >
> Hi Dave,
> I was going to pull this into -tip, but I need a Signed-off-by: line in
> order to do so. Could you resend this so we can add it to -tip?

Yeah, I was going to rediff against tip and resend them, but I went
into the office instead yesterday, where nothing productive ever happens :-)

I'll get to it today.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at