RE: [PATCH 3/4] [MMC] mmc_spi: add polling support for the carddetectline

From: Chen Gong
Date: Thu May 22 2008 - 09:45:22 EST




> -----Original Message-----
> From: Anton Vorontsov [mailto:avorontsov@xxxxxxxxxxxxx]
> Sent: 2008?5?22? 20:39
> To: Chen Gong
> Cc: Kumar Gala; David Brownell; Pierre Ossman;
> linuxppc-dev@xxxxxxxxxx;
> spi-devel-general@xxxxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Tabi Timur
> Subject: Re: [PATCH 3/4] [MMC] mmc_spi: add polling support
> for the carddetectline
>
> On Mon, May 19, 2008 at 11:02:13AM +0800, Chen Gong wrote:
> >
> > > -----Original Message-----
> > > From: linuxppc-dev-bounces+b11801=freescale.com@xxxxxxxxxx
> > > [mailto:linuxppc-dev-bounces+b11801=freescale.com@xxxxxxxxxx]
> > > On Behalf Of Anton Vorontsov
> > > Sent: 2008?5?17? 0:51
> > > To: Kumar Gala; David Brownell; Pierre Ossman
> > > Cc: linuxppc-dev@xxxxxxxxxx;
> > > spi-devel-general@xxxxxxxxxxxxxxxxxxxxx;
> > > linux-kernel@xxxxxxxxxxxxxxx; Tabi Timur
> > > Subject: [PATCH 3/4] [MMC] mmc_spi: add polling support
> for the card
> > > detectline
> > >
> > > Some boards do not use interrupts on the CD line, so we
> want to poll
> > > the CD and see if there was a change. 1 second poll
> interval seems
> > > resonable.
> > >
> > > Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
> > > ---
> > > drivers/mmc/host/mmc_spi.c | 51
> >
> > I want to know whether every card working well ? Because
> I'm working
> > For 83xx MMC-over-SPI support, the presented concrete
> methods I used
> > as you do, but only 256M card seems good, 512M or 1G/2G
> card all have
> > some problems
>
> So far I don't have cards larger than 256M. Will try to get
> one though.
>
Thanks, if you have any new test report pls contact me.

BTW, a fews days ago Joakim Tjernlund made a heavy fix for
spi_mpc83xx.c to resolve clock glitch. But it looks no any impact
for me, but maybe it has positive effect for you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/