Re: [PATCH 2/5] sky2: don't warn if page allocation fails

From: Jeff Garzik
Date: Thu May 22 2008 - 05:58:00 EST

for (i = 0; i < sky2->rx_nfrags; i++) {
- struct page *page = alloc_page(GFP_ATOMIC);
+ struct page *page = alloc_page(GFP_ATOMIC | __GFP_NOWARN);
if (!page)
goto free_partial;

IMO it's inappropriate to add these warnings to net drivers that properly check all return values.

This approach is too maintenance intensive, and winds up fixing the same problem over and over again -- a hint that the fix is in the wrong place.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at