Re: Moving include/asm-* [was: Re: Moving sound/* to drivers/ ?]

[Al Viro]

On Wed, May 21, 2008 at 04:51:57PM -0700, Linus Torvalds wrote:

> So the trivial alternative is to just do
> 
> 	git mv include/asm-xyz arch/xyz/include

Careful - arch/um/include/ exists, so that'll get interesting.

> But the alternative I'd actually *prefer* would avoid the symlink, and 
> would be roughly:
> 
> 	for i in $(arch-list)
> 	do
> 		mkdir arch/$i/include
> 		git mv include/asm-$i arch/$i/asm
> 		
> 	done
> 	git mv include/asm-generic include/asm
> 
> and then remove the symlink to asm entirely, and instead add a 
> -Iarch/xyz/include, and put that as the *first* entry in the include path.

Eh?  git mv include/asm-$i arch/$i/include/asm, then?

> This would mean that:
> 
>  - no symlink games
> 
>  - if some architecture just uses the generic header file, it doesn't need 
>    to do anything: it just wouldn't implement that header file at all, and 
>    the next entry in the search-path would just find the generic 
>    include/asm entry.

Nice, but... how do you pull what's currently asm-generic/foo.h from what's
currently asm-bar/foo.h?  #include_next is _ugly_...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/