Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocatorpass-through

From: Pekka Enberg
Date: Wed May 21 2008 - 17:18:05 EST


Christoph Lameter wrote:
Hmm, where? page_address() already references ->virtual. I suppose
CONFIG_SLUB_DEBUG is a no no as well then so do we want to add a
CONFIG_KSIZE_DEBUG config option...? (Btw, I removed the BUG_ON() from kfree()
as spotted by Vegard Nossum.)

If it has to be then add CONFIG_KSIZE_DEBUG. There are a number of debugging techniques (kmem_check?) that should not be compiled in. Maybe add a new config option for those. CONFIG_SLUB_ENABLE_EXPENSIVE_DEBUG?

Oh, kmemcheck is a separate config option already and it's *much much* more expensive than the ksize() checks will ever be so they shouldn't be bundled together anyway.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/