Re: [2.6 patch] scsi/advansys.c: fix compile errors

[Adrian Bunk]

On Wed, May 21, 2008 at 01:53:33PM -0600, Matthew Wilcox wrote:
> On Wed, May 21, 2008 at 08:41:52PM +0300, Adrian Bunk wrote:
> > This patch fixes the following compile error on architectures not 
> > providing free_dma():
> 
> Last time this came up, I think the consensus was that those
> architectures should be providing a stub free_dma().

I tried building as many modules as possible on frv, and this was the 
only driver that failed this way.

Another possibility would be to let this driver depend on ISA_DMA_API
(similar to e.g. SCSI_EATA).

Sorry for being lazy, but touching X architectures for fixing the 
compiliation of a driver whose hardware will anyway most likely never
be used on this architecture is IMHO not worth the effort...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/