Re: [PATCH 1/3] signals: sigqueue_free: don't free sigqueue if itis queued

[Roland McGrath]

> I thought we didn't even know which queue it was pending on if it was 
> already on a thread-local queue. So we could remove the entry, but I 
> always objected to the games with the pending bit.

Removing the entry without fixing the pending set is the bug we're trying
to fix.  That's what it does now, and it's wrong.

Oleg had a patch that marked the sigqueue entry with whether it was on the
shared queue or not.  The caller in timer_delete knows which thread it is
when it's on a thread queue, and whether it's on the shared queue.  So it
could be the caller's responsibility to know, i.e. its sigqueue_free call
matches its send_sigqueue call.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/