Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocatorpass-through

[Christoph Lameter]

On Wed, 21 May 2008, Pekka J Enberg wrote:

> This patch changes ksize() to be more strict with objets passed to it. We now
> set PageSlab also for objects allocated with page allocator and use page->slab
> to check whether page is a regular slab page or a pass-through page.
> 
> Also moves kmalloc_large() out-of-line as it's too big for inlining now.

Why is it too big? Without your additions it is converting kmallocs 
inline to get_free_pages(). That results in a simple function call with 
two constant parameters.

The patch touches the page struct uselessly. I think the PageSlab marking 
is useful for debugging but not for a production kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/