[patch 05/14] hpfs: dont call permission()

From: Miklos Szeredi
Date: Wed May 21 2008 - 13:19:17 EST

From: Miklos Szeredi <mszeredi@xxxxxxx>

hpfs_unlink() calls permission() prior to truncating the file. HPFS
doesn't define a .permission method, so replace with explicit call to

This is equivalent, except that devcgroup_inode_permission() and
security_inode_permission() are not called.

The truncation is just an implementation detail of the unlink, so
these security checks are unnecessary.

I suspect that even calling generic_permission() is unnecessary, since
we shouldn't mind if the file isn't writable. But I leave that to the
maintainer to decide.

Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
CC: Mikulas Patocka <mikulas@xxxxxxxxxxxxxxxxxxxxxxxx>
fs/hpfs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/fs/hpfs/namei.c
--- linux-2.6.orig/fs/hpfs/namei.c 2008-05-21 13:13:29.000000000 +0200
+++ linux-2.6/fs/hpfs/namei.c 2008-05-21 13:41:25.000000000 +0200
@@ -415,7 +415,7 @@ again:
if (atomic_read(&dentry->d_count) > 1 ||
- permission(inode, MAY_WRITE, NULL) ||
+ generic_permission(inode, MAY_WRITE, NULL) ||
!S_ISREG(inode->i_mode) ||
get_write_access(inode)) {

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/