Re: [PATCH] [POWERPC] Add i2c pins to dts and board setup

From: Jochen Friedrich
Date: Wed May 21 2008 - 12:17:31 EST


Hi Scott,

>> + - linux,i2c-index : Can be used to hard code an i2c bus number.
>> + - linux,i2c-class : Can be used to override the i2c class.
>
> Why do we need this?

There are still a bunch of i2c drivers using the old API (mainly v4l and dvb stuff)
which are slowly being converted by their subsystem maintainers, though.

> It'd be better to just convert any needed old-style drivers than add this
> to the device tree.

Sure. That's why the parameters are only optional. Once all i2c drivers are
converted, these parameters won't be used anymore. Maybe they should be marked
as deprecated.

>> + - bus-frequency : Can be used to set the i2c bus frequency. If unspecified,
>> + a default frequency of 60kHz is being used.
>
> clock-frequency is the standard name for such things.

I was just confused by the fact that unlike a serial port, i2c is a bus itself.

Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/