[PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper_find()

From: Kamalesh Babulal
Date: Wed May 21 2008 - 07:32:47 EST

Hi Stephen,

The next-20080521 kernel build fails, on x86_64 machine

CC net/netfilter/nf_conntrack_helper.o
net/netfilter/nf_conntrack_helper.c: In function â__nf_ct_helper_findâ:
net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function âhlist_for_each_entry_rcuâ
net/netfilter/nf_conntrack_helper.c:58: error: âhnodeâ undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
net/netfilter/nf_conntrack_helper.c:58: error: expected â;â before â{â token
net/netfilter/nf_conntrack_helper.c:50: warning: unused variable âmaskâ
net/netfilter/nf_conntrack_helper.c: In function â__nf_conntrack_helper_find_bynameâ:
net/netfilter/nf_conntrack_helper.c:74: error: âhnodeâ undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:74: error: expected â;â before â{â token
net/netfilter/nf_conntrack_helper.c: In function ânf_conntrack_helper_registerâ:
net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function âhlist_add_head_rcuâ
net/netfilter/nf_conntrack_helper.c: In function ânf_conntrack_helper_unregisterâ:
net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function âhlist_del_rcuâ
make[2]: *** [net/netfilter/nf_conntrack_helper.o] Error 1
make[1]: *** [net/netfilter] Error 2
make: *** [net] Error 2

This build error is because of the missing include file.I have tested
the patch for the build failure only.

Signed-off-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx>
--- linux-2.6.26-rc3/net/netfilter/nf_conntrack_helper.c 2008-05-20 20:24:14.000000000 +0530
+++ linux-2.6.26-rc3/net/netfilter/~nf_conntrack_helper.c 2008-05-22 00:17:32.000000000 +0530
@@ -20,6 +20,7 @@
#include <linux/err.h>
#include <linux/kernel.h>
#include <linux/netdevice.h>
+#include <linux/rculist.h>

#include <net/netfilter/nf_conntrack.h>
#include <net/netfilter/nf_conntrack_l3proto.h>
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/