Re: [RFC][PATCH 0/3] configfs: Make nested default groupslockdep-friendly

From: Arjan van de Ven
Date: Tue May 20 2008 - 12:58:38 EST


On Tue, 20 May 2008 18:33:20 +0200
Louis Rilling <Louis.Rilling@xxxxxxxxxxx> wrote:

> Hi all,
>
> The following patches fix lockdep warnings resulting from (correct)
> recursive locking in configfs.
>
> Current lockdep annotations for inode mutexes in configfs are
> lockdep-friendly provided that:
> 1/ config_groups have at most one level of default groups (see
> configfs_attach_group()),
> 2/ config_groups having default groups are never removed (see
> configfs_detach_prep()).
>
> Since lockdep does not handle such correct recursion, the idea is to
> insert lockdep_off()/lockdep_on() for inode mutexes as soon as the
> level of recursion of the I_MUTEX_PARENT -> I_MUTEX_CHILD dependency
> pattern increases.

I'm... not entirely happy with such a solution ;(

there must be a better one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/