Re: [X86] Add recent Centaur CPUs to PAT whitelist

From: Dave Jones
Date: Tue May 20 2008 - 10:32:19 EST


On Mon, May 19, 2008 at 10:49:28PM -0700, Yinghai Lu wrote:

> > + case X86_VENDOR_CENTAUR:
> > + if ((c->x86 > 6) || (c->x86 == 6 && c->x86_model >= 10))
> > + set_cpu_cap(c, X86_FEATURE_PAT);
> > + break;
> > }
> >
> > pat_disable(cpu_has_pat ?
>
> you may need to return early...

Argh, old version of the patch. This one should be right.

Dave

---


>From conversation with Centaur engineers, both the newer generations
of the VIA C7, and their future CPUs support PAT, with no known errata.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

diff --git a/arch/x86/kernel/cpu/addon_cpuid_features.c b/arch/x86/kernel/cpu/addon_cpuid_features.c
index c2e1ce3..b9f14f9 100644
--- a/arch/x86/kernel/cpu/addon_cpuid_features.c
+++ b/arch/x86/kernel/cpu/addon_cpuid_features.c
@@ -62,6 +62,10 @@ void __cpuinit validate_pat_support(struct cpuinfo_x86 *c)
if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >= 15))
return;
break;
+ case X86_VENDOR_CENTAUR:
+ if ((c->x86 > 6) || (c->x86 == 6 && c->x86_model >= 10))
+ return;
+ break;
}

pat_disable(cpu_has_pat ?


--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/