Re: [PATCH, RFC] Char dev BKL pushdown v2

From: Stefan Richter
Date: Mon May 19 2008 - 15:28:22 EST

I wrote:
Jonathan Corbet wrote:
drivers/ieee1394/dv1394.c | 6 +++-
drivers/ieee1394/raw1394.c | 3 ++
drivers/ieee1394/video1394.c | 18 +++++++++---
ieee1394: cdev lock_kernel() pushdown

I have yet to look at these drivers in detail whether they need BKL or not. They likely don't.

video1394 needs it to serialize module init vs. open. The race condition there can be prevented by splitting hpsb_register_highlevel() into an _init and a _register function. I will follow up with a patch.

dv1394 and raw1394 do not need the BKL in their open() methods AFAICS.
Stefan Richter
-=====-==--- -=-= =--==
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at