Re: [PATCH 1/1] mtd maps - Blackfin Async Flash Maps (try #4): Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

From: JÃrn Engel
Date: Mon May 19 2008 - 07:19:48 EST

On Mon, 19 May 2008 18:32:24 +0800, Bryan Wu wrote:
> [try #4]
> - drop superfluous casts
> - drop SSYNC() when reading from the flash and rewrite
> bfin_copy_from() to be like bfin_copy_to() so that
> we dont have to handle all the aligned/unaligned cases
> [try #3] rename bf5xx-flash to bfin-async-flash
> - move all kconfig board settings into board resources
> - fixup casting style according to lkml feedback
> - rewrite driver so that it can handle arbitrary of
> instances according to the declared platform resources
> [try #2]
> Remove useless SSYNC() as Will said
> [try #1]
> The BF533-STAMP does this for example.
> All board-specific configuration goes in your board resources file.
> Signed-off-by: Mike Frysinger <vapier.adi@xxxxxxxxx>
> Cc: Joern Engel <joern@xxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>

Looks good to me. If dwmw2 doesn't mind adding another mapping driver,
this can go in. Not that I had any idea how physmap could sanely cover
this driver too.

Acked-By: Joern Engel <joern@xxxxxxxxx>


Ninety percent of everything is crap.
-- Sturgeon's Law
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at