Re: [PATCH 2/6] ERR_PTR: add ERR_OR_0_PTR

From: Christoph Hellwig
Date: Mon May 19 2008 - 01:55:28 EST

On Mon, May 19, 2008 at 12:01:07AM +0200, Marcin Slusarz wrote:
> Some codepaths call ERR_PTR with possibly 0 argument, which is not
> a valid errno and rely on conversion from 0 to NULL pointer.
> Add ERR_OR_0_PTR function which accepts errnos and 0 as an argument.

Sorry, no. ERR_PTR(0) is perfectly valid, you just don't want to return
the actualy value. E.g. we have a common idiom of:

some_ptr = ERR_PTR(err);
if (IS_ERR(some_ptr))
goto out_handle_err;

and obsfucating this with new syntactic sugar is not a good idea.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at