Re: [RFC] x86: merge nmi_32-64 to nmi.c

[Adrian Bunk]

On Sun, May 18, 2008 at 07:38:41PM +0100, Maciej W. Rozycki wrote:
> On Sun, 18 May 2008, Adrian Bunk wrote:
> 
> > Even more important:
> > How do you want to handle kconfig variables set to "m"?
> > 
> > Expand them to 0.5 ?  ;-)
> 
>  :-)
> 
>  Modules use a separate set of variables with _MODULE appended to their 
> names.  Thus for an option FOO, you'll get:
> 
> #undef CONFIG_FOO
> #undef CONFIG_FOO_MODULE
> 
> if it's set to "n",
> 
> #define CONFIG_FOO 1
> #undef CONFIG_FOO_MODULE
> 
> if it's set to "y", and
> 
> #undef CONFIG_FOO
> #define CONFIG_FOO_MODULE 1
> 
> if it's set to "m".  Individual tests may check these both as they find 
> appropriate.

I do know that.


But your suggestion was:

static inline unsigned int get_nmi_count(int cpu)
{
        return cpu_x86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
}


And Jeremy said "It would be nice if CONFIG_* expanded to 0/1".


My point was simply that like most of the fun^Wproblems we already have 
in kconfig also here the tristate logic we need would make stuff more 
tricky.


>   Maciej

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/