Re: [PATCH] virtio_net: free transmit skbs in a timer

From: Avi Kivity
Date: Sun May 18 2008 - 10:27:23 EST

Rusty Russell wrote:
OK. And since the current situation is that the host doesn't throttle, the feature bit should be "don't throttle, host is doing it for you", and Mark's patch should go in...


We should have thought of this before, though, especially as Xen does this or something very similar:

/* Shared ring page */ \
struct __name##_sring { \
RING_IDX req_prod, req_event; \
RING_IDX rsp_prod, rsp_event; \
uint8_t pad[48]; \
union __name##_sring_entry ring[1]; /* variable-length */ \
}; \

req_event and rsp_event allow the other side to indicate when it wants a notification.

Do not meddle in the internals of kernels, for they are subtle and quick to panic.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at