Re: [RFC] x86: merge nmi_32-64 to nmi.c

From: Cyrill Gorcunov
Date: Sun May 18 2008 - 05:13:45 EST

[Jeremy Fitzhardinge - Sun, May 18, 2008 at 09:33:14AM +0100]
> Cyrill Gorcunov wrote:
>> I think I would prefer Maciej's advice then but with capital
>> letters (to easy distinguish them and point an attention) like
>> #ifdef CONFG_X86_64
>> #define CPU_64 1
>> #else
>> #define CPU_64 0
>> #endif
> The other problem in this case is that cpu_pda() doesn't exit for 32-bit,
> so it probably won't compile anyway. But in general, I fully support using
> if (constant) over #ifdef (?: not so much).
> J

yep, you're right - gcc doesn't throw it out but tries to evaluate in any
case so this trick with () ? : ; would not work :( or we should define
dummy types for this case...

- Cyrill -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at