Re: [PATCH 5/6] RTC: SMBus support for the M41T80, etc. driver (#2)

From: Maciej W. Rozycki
Date: Sat May 17 2008 - 16:49:26 EST

On Sun, 18 May 2008, Atsushi Nemoto wrote:

> I suppose the "off by one second" issue is not the matter each driver
> should take care of. This race is common for most RTC chip.

I agree, but with the reread it comes for free here. Given you have two
values of seconds available here, which one would you choose? You can't
take both at once. ;-)

> I do not have strong opinion for optimization suggested by Jean. It
> might be better, but I'm OK with current your patch.

Hmm, it looks as simple as putting a clause like:

if (i2c_check_functionality(client->adapter,

into the loop and even at 400kHz it saves a considerable amount of time.
It sounds plausible -- I'll do that.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at