Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed

From: Oleg Nesterov
Date: Sat May 17 2008 - 11:31:22 EST


On 05/17, Oleg Nesterov wrote:
>
> This is a user visible change. With this patch sys_timer_delete() discards
> the pending signal which was generated by the timer.

If this change is undesirable, we can (for example) do

--- kernel/posix-timers.c
+++ kernel/posix-timers.c
@@ -885,6 +885,7 @@ itimer_delete(struct k_itimer *timer)
timer->it_process = NULL;

unlock_timer(timer, flags);
+ tmr->sigq->flags |= SIGQUEUE_CANCELLED;
release_posix_timer(timer, IT_ID_SET);
}

instead, and still fix the "BUG 10460".

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/