Re: [patch 07/22] fat: dont call notify_change

[OGAWA Hirofumi]

Miklos Szeredi <miklos@xxxxxxxxxx> writes:

> From: Miklos Szeredi <mszeredi@xxxxxxx>
>
> The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change
> the file mode before changing the inode attributes.  Replace with
> explicit calls to security_inode_setattr(), fat_setattr() and
> fsnotify_change().
>
> This is equivalent to the original.  The reason it is needed, is that
> later in the series we move the immutable check into notify_change().
> That would break the FAT_IOCTL_SET_ATTRIBUTES ioctl, as it needs to
> perform the mode change regardless of the immutability of the file.
>
> Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
> CC: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>

Don't we need to add EXPORT_SYMBOL(security_inode_setattr)? Otherwise,
looks good to me.

Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/