Re: thinkpad_acpi: fix possible NULL pointer dereference if kstrdup for ec_version_str failed

From: Henrique de Moraes Holschuh
Date: Fri May 16 2008 - 11:54:57 EST

On Fri, 16 May 2008 11:34:09 +0200, "Jan Lieskovsky" <jlieskov@xxxxxxxxxx> said:
> There is a potential NULL pointer dereference in
> thinkpad_acpi_module_exit() -- in case,
> kstrdup for thinkpad_id.ec_version_str failed.

One can kfree(NULL) without problems. Is there any other unprotected access to ec_version_str that I failed to see?

"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at