Re: [PATCH] remove double indirection on tlb parameter tofree_pgd_range()& Co

From: Jan Beulich
Date: Fri May 16 2008 - 11:30:22 EST


>>> Hugh Dickins <hugh@xxxxxxxxxxx> 16.05.08 16:39 >>>
> Pass mmu_gather** in the
> public interfaces, since we might want to add latency lockdrops later;
> but no attempt to do so yet, going by vma should itself reduce latency.
>...
>But, returning to the start, please let's hold yours back after all.

If you want to keep and actively use the double indirection, would you
guarantee current semantics like ->mm and ->fullmm to always be what
was specified at the start of the operation? Verifying this was what
made me go through that call tree in the first place, and obviously this
is harder to verify when there is potential for the whole structure
pointed to to be replaced by another one.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/